-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping and using DejaVu font on Ms-Windows Improved #270
Shipping and using DejaVu font on Ms-Windows Improved #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good enough (I could only test this on linux, so I cannot say anything about the actual functionality :-))
@umlaeute I will do a w32 build to re-test. |
a rebuild is probably unnecessary, as you are not touching any files that need to be compiled (aka "built"). of course, testing the generated "application bundle" (that is, the zip-file and the installer as would be shipped by miller) would be a good thing. |
Ok, I build this branch just to test. I'm using Christof's #258 makefiles. He unpacks "pdprototype.tgz" in a way similar to Miller I think:
The resulting build includes properly the fonts and twapi. So the “compiled Pd dir” is working. I cant test the “Installer” but I guess it will just work. I can't find the package “mingw32-nsis” for windows needed in https://github.com/pure-data/pure-data/blob/master/msw/build-nsi.sh. I'm using MinGW Msys1. I think the installer will work as it copies from the already "compiled Pd dir". |
If someone want to test functionality here's a Zip version: http://lucarda.com.ar/x/dejavu/pd-dejavu-test-w32.zip It must be tested on a windows machine with no dejavu font installed. Note: sign out of windows if you uninstalled the font. This has been built with MinGW Msys1.0. These 2 extra files on the pd/bin folder are not necessary on Miller's build (also are not included on "pdprototype.tgz").:
I used Christof's makefiles #258 with the “install” option. |
I'm closing this PR because something better is comming here: |
This PR includes the fonts and TWAPI on "pdprototype.tgz" included on the [MSW folder] https://github.com/pure-data/pure-data/tree/master/msw
Fonts are placed on the pd/bin
TWAPI and resources on pd/lib
The fonts are loaded on pd-gui.tcl and protected with a catch clause if TWAPI is not present.
This is an improved #269